Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #91

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Update dependencies #91

merged 1 commit into from
Nov 17, 2017

Conversation

TimothyGu
Copy link
Member

webidl2.js has dropped official support for Node.js v6.x in v8.0.0 (which we still want to support), but it still fully works with it (as shown by our test suite). Let's wait until w3c/webidl2.js#102 (comment) is resolved before this is merged.

@domenic
Copy link
Member

domenic commented Nov 12, 2017

FWIW jsdom doesn't support all LTS by policy. If there's something in 7, 8, or even 9 that makes our lives easier, we'd change the required Node version, as we have in the past. I just haven't seen such a thing yet... Although the VM module fixes certainly help with a lot of bugs.

@TimothyGu
Copy link
Member Author

webidl2.js has added back support for Node.js v6.x. Let's merge this.

@TimothyGu TimothyGu merged commit 363e1e0 into jsdom:master Nov 17, 2017
@TimothyGu TimothyGu deleted the updates branch November 17, 2017 21:37
@Zirro Zirro mentioned this pull request Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants